Build only cloud image variant when it's requested #6408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdner
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Before this change we were building all possible Docker images to produce the cloud image. Which is unnecessary and takes a long time. Now only the `cloud` variant is built.
rdner
force-pushed
the
faster-cloud-image-build
branch
from
1b352dd to
e06c01d
Compare
|
rdner
requested review from
ycombinator,
jlind23 and
pchila
and removed request for
swiatekm
jlind23
approved these changes
Dec 30, 2024
|
Looks good to me. |
michalpristas
approved these changes
Dec 31, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Before this change we were building all possible Docker images to produce the cloud image. Which is unnecessary and takes a long time. Now only the `cloud` variant is built. (cherry picked from commit 63686c4)
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Before this change we were building all possible Docker images to produce the cloud image. Which is unnecessary and takes a long time. Now only the `cloud` variant is built. (cherry picked from commit 63686c4)
mergify bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Before this change we were building all possible Docker images to produce the cloud image. Which is unnecessary and takes a long time. Now only the `cloud` variant is built. (cherry picked from commit 63686c4)
jlind23
pushed a commit
that referenced
this pull request
Dec 31, 2024
Before this change we were building all possible Docker images to produce the cloud image. Which is unnecessary and takes a long time. Now only the `cloud` variant is built. (cherry picked from commit 63686c4) Co-authored-by: Denis <[email protected]>
jlind23
pushed a commit
that referenced
this pull request
Dec 31, 2024
Before this change we were building all possible Docker images to produce the cloud image. Which is unnecessary and takes a long time. Now only the `cloud` variant is built. (cherry picked from commit 63686c4) Co-authored-by: Denis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we were building all possible Docker images to produce the cloud image. Which is unnecessary and takes a long time.
Now only the
cloudvariant is built.On my machine this reduces this build time from 27 to 20 minutes.
For testing:
Or follow this guide https://github.com/elastic/elastic-agent?tab=readme-ov-file#testing-on-elastic-cloud